-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable pip cache in appveyor and travis builds #5036
Conversation
This is a build change so if someone can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thijstriemstra: why don't you mention your rational for this change? This seems important as from a performance standpoint the gains (if any) are negligible.
Additionally, shouldn't the same be done for Travis?
Ping @thijstriemstra |
@pradyunsg thanks for pinging me. The reason for this pull request is the same reason caching was added to pip: we want to minimze the amount of traffic and load on the pypi site. Downloading any package(s) from pypi more than once is a waste of resources. You're right that travis should cache as well, I'll update this PR. |
ping @benoit-pierre @pradyunsg can this be merged? |
Could you merge the current master into this PR? Once that works, I'll happily merge. :) |
I don't see any merge conflicts at the moment, so I wonder why? |
Just to be sure. :) |
@pradyunsg if you can give me the steps, I will give it a try. |
Oh, sure! Are you comfortable with the command line/terminal? |
Yep. |
(sorry for the delay in responding) Essentially, you'd want to locally fetch a reference to the current master branch of github.com/pypa/pip. Once you have that, you can just run I'll present 2 ways of doing this:
|
@pradyunsg Done, thanks for the feedback. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The reason for this pull request is the same reason caching was added to pip: we want to minimze the amount of traffic and load on the pypi site. Downloading any package(s) from pypi more than once is a waste of resources.