Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pip cache in appveyor and travis builds #5036

Merged
merged 3 commits into from
Apr 30, 2018

Conversation

thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Feb 20, 2018

The reason for this pull request is the same reason caching was added to pip: we want to minimze the amount of traffic and load on the pypi site. Downloading any package(s) from pypi more than once is a waste of resources.

@thijstriemstra
Copy link
Contributor Author

This is a build change so if someone can add the trivial label to this PR..

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes labels Feb 20, 2018
Copy link
Member

@benoit-pierre benoit-pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thijstriemstra: why don't you mention your rational for this change? This seems important as from a performance standpoint the gains (if any) are negligible.

Additionally, shouldn't the same be done for Travis?

@pradyunsg pradyunsg added the S: awaiting response Waiting for a response/more information label Mar 1, 2018
@pradyunsg
Copy link
Member

Ping @thijstriemstra

@thijstriemstra
Copy link
Contributor Author

@pradyunsg thanks for pinging me. The reason for this pull request is the same reason caching was added to pip: we want to minimze the amount of traffic and load on the pypi site. Downloading any package(s) from pypi more than once is a waste of resources.

You're right that travis should cache as well, I'll update this PR.

@thijstriemstra thijstriemstra changed the title enable pip cache in appveyor build enable pip cache in appveyor and travis builds Mar 1, 2018
@pradyunsg pradyunsg removed the S: awaiting response Waiting for a response/more information label Mar 1, 2018
@thijstriemstra
Copy link
Contributor Author

ping @benoit-pierre @pradyunsg can this be merged?

@pradyunsg
Copy link
Member

Could you merge the current master into this PR? Once that works, I'll happily merge. :)

@thijstriemstra
Copy link
Contributor Author

Could you merge the current master into this PR? Once that works, I'll happily merge. :)

I don't see any merge conflicts at the moment, so I wonder why?

@pradyunsg
Copy link
Member

Just to be sure. :)

@thijstriemstra
Copy link
Contributor Author

@pradyunsg if you can give me the steps, I will give it a try.

@pradyunsg
Copy link
Member

Oh, sure!

Are you comfortable with the command line/terminal?

@thijstriemstra
Copy link
Contributor Author

Yep.

@pradyunsg
Copy link
Member

(sorry for the delay in responding)

Essentially, you'd want to locally fetch a reference to the current master branch of github.com/pypa/pip. Once you have that, you can just run git merge <that reference> or equivalent.

I'll present 2 ways of doing this:

@thijstriemstra
Copy link
Contributor Author

@pradyunsg Done, thanks for the feedback.

@pradyunsg pradyunsg merged commit 80b9524 into pypa:master Apr 30, 2018
@thijstriemstra thijstriemstra deleted the patch-1 branch April 30, 2018 14:37
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants